ci(checkout): check out correct fork/branch during PR CI run #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
pr-ci-checkout-branch
branch
2 times, most recently
from
950f88a to
298e19a
Compare
andrewazores
force-pushed
the
pr-ci-checkout-branch
branch
from
298e19a to
b8e59e1
Compare
This was referenced Oct 26, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1118
Related to #1133
Previous PR to change the trigger event to
pull_request_targetchanges the runner context to the base repo's. This means thecheckoutaction in various CI steps is actually just checking out the upstreammainbranch, rather than the PR branch. This update corrects thecheckoutaction to check out the PR branch for PRs, or leave it as the defaults after final push. This is what we talked about on an earlier call and is what we thought the new PR flow would actually be doing.